feat(core): Add log streaming events for external secrets provider #23990
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phyllis-noester
changed the title
phyllis-noester
changed the title
phyllis-noester
changed the title
n8n-assistant
bot
added
core
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 7m 0.4s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
MarcL
requested changes
Jan 7, 2026
Contributor
MarcL
left a comment
MarcL
left a comment
There was a problem hiding this comment.
Looking great! Thanks for your first PR @phyllis-noester! 🎉
Just some minor nits about naming consistency.
| eventService.emit('external-secrets-provider-settings-saved', event); | ||
|
|
||
| expect(eventBus.sendAuditEvent).toHaveBeenCalledWith({ | ||
| eventName: 'n8n.audit.external-secrets-provider-settings.saved', |
Contributor
Author
There was a problem hiding this comment.
good point thanks! added the requested changes :)
packages/cli/src/events/__tests__/log-streaming-event-relay.test.ts
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
MarcL
reviewed
Jan 8, 2026
Co-authored-by: Marc Littlemore <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two new log streaming events will be sent:
n8n.audit.external-secrets-provider-settings.savedwhenever a new secrets provider is added or an existing one is updated (this is handled identically in the code). tested locallyexternal-secrets-provider-reloadedwhenever a secrets provider is reloaded meaning the secrets are refetched. I was not able to test that locally because I don't have valid credentials to a secrets storeYou can test this by setting up log streaming locally and seeing an event arrive when you update a secrets provider
setting up log streaming locally: https://github.com/n8n-io/n8n/blob/29bd48acbd6d52d93b9f0424db3c9a9a7c2a80bf/packages/cli/test/integration/eventbus/README-manual-test-syslog.md
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2932/log-streaming-add-external-secrets
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)