Skip to content

Conversation

@osasisorae
Copy link

Summary

  • prevent FilterConditions from emitting stale debounced updates after switching nodes by capturing the node name, flushing on node change/unmount, and skipping emits when no node is active
  • reuse the same scheduling helper for async option updates so delayed loads can’t overwrite other nodes’ parameters
  • verified manually (editing adjacent If nodes) and via pnpm exec vitest run src/features/ndv/parameters/components/FilterConditions/FilterConditions.test.ts

Related Linear tickets, Github issues, and Community forum posts

  • N/A

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR labeled with release/backport if needed.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Jan 7, 2026
@n8n-assistant
Copy link
Contributor

n8n-assistant bot commented Jan 7, 2026

Hey @osasisorae,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-6214". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Authored by a community member in linear Issue or PR has been created in Linear for internal review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant