Skip to content

fix(Google Drive Node): Continue on error support for download file operation#28276

Open
RomanDavydchuk wants to merge 2 commits intomasterfrom
node-4712-community-issue-google-drive-download-file-node-doesnt
Open

fix(Google Drive Node): Continue on error support for download file operation#28276
RomanDavydchuk wants to merge 2 commits intomasterfrom
node-4712-community-issue-google-drive-download-file-node-doesnt

Conversation

@RomanDavydchuk
Copy link
Copy Markdown
Contributor

@RomanDavydchuk RomanDavydchuk commented Apr 9, 2026

Summary

V2 of Google Drive node for some reason didn't properly handle this.continueOnFail() if the operation is download and resource is file. It was like this since the original overhaul PR, so it is not clear why it was done this way. But it means that if the node errors when downloading a file and continue on error is enabled - the node outputs nothing. This PR fixes that and makes sure that all operations are handled on error

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-4712/community-issue-google-drive-download-file-node-doesnt-continue-on
Closes #27312

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@RomanDavydchuk RomanDavydchuk marked this pull request as ready for review April 9, 2026 20:42
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nodes-base/nodes/Google/Drive/v2/actions/router.ts 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Joffcom Joffcom requested a review from ShireenMissi April 9, 2026 20:44
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Architecture diagram
sequenceDiagram
    participant Engine as Workflow Engine
    participant Router as Google Drive Node (Router)
    participant API as Google Drive API

    Note over Engine, API: Loop for each input item

    Engine->>Router: execute(item)
    Router->>API: Request File Download (v3)

    alt Success Path
        API-->>Router: 200 OK (File Stream)
        Router->>Router: Process binary data
        Router-->>Engine: INodeExecutionData (Binary)
    else Error Path (e.g., 404 File Not Found)
        API-->>Router: Error Response
        Router->>Router: catch(error)

        alt NEW: continueOnFail() is ENABLED
            Router->>Router: CHANGED: Push error message to returnData
            Note right of Router: This ensures the node outputs<br/>the error JSON instead of nothing.
            Router-->>Engine: INodeExecutionData (JSON with error)
        else continueOnFail() is DISABLED
            Router-->>Engine: throw NodeOperationError
            Note right of Engine: Workflow stops (standard behavior)
        end
    end

    Note over Router, API: Next item or finish execution
Loading

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/improvement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Drive "Download File" Node Doesn't Continue on Error

1 participant