fix(Google Drive Node): Continue on error support for download file operation#28276
Open
RomanDavydchuk wants to merge 2 commits intomasterfrom
Open
fix(Google Drive Node): Continue on error support for download file operation#28276RomanDavydchuk wants to merge 2 commits intomasterfrom
RomanDavydchuk wants to merge 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Architecture diagram
sequenceDiagram
participant Engine as Workflow Engine
participant Router as Google Drive Node (Router)
participant API as Google Drive API
Note over Engine, API: Loop for each input item
Engine->>Router: execute(item)
Router->>API: Request File Download (v3)
alt Success Path
API-->>Router: 200 OK (File Stream)
Router->>Router: Process binary data
Router-->>Engine: INodeExecutionData (Binary)
else Error Path (e.g., 404 File Not Found)
API-->>Router: Error Response
Router->>Router: catch(error)
alt NEW: continueOnFail() is ENABLED
Router->>Router: CHANGED: Push error message to returnData
Note right of Router: This ensures the node outputs<br/>the error JSON instead of nothing.
Router-->>Engine: INodeExecutionData (JSON with error)
else continueOnFail() is DISABLED
Router-->>Engine: throw NodeOperationError
Note right of Engine: Workflow stops (standard behavior)
end
end
Note over Router, API: Next item or finish execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V2 of Google Drive node for some reason didn't properly handle
this.continueOnFail()if the operation isdownloadand resource isfile. It was like this since the original overhaul PR, so it is not clear why it was done this way. But it means that if the node errors when downloading a file and continue on error is enabled - the node outputs nothing. This PR fixes that and makes sure that all operations are handled on errorRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-4712/community-issue-google-drive-download-file-node-doesnt-continue-on
Closes #27312
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)