fix(core): Resolve managed OAuth endpoint fields from the credential type (no-changelog) - #36922
Queued
afitzek wants to merge 2 commits into
Queued
fix(core): Resolve managed OAuth endpoint fields from the credential type (no-changelog)#36922afitzek wants to merge 2 commits into
afitzek wants to merge 2 commits into
Conversation
…type (no-changelog)
Contributor
PR review overviewBased on ownership of the 3 changed files in this PR:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
afitzek
marked this pull request as ready for review
August 24, 2026 13:23
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Architecture diagram
sequenceDiagram
participant W as Workflow Executor
participant CH as CredentialsHelper
participant CO as CredentialsOverwrites
participant CT as CredentialTypes
participant DB as Credentials Repository
Note over W,DB: Runtime Credential Resolution Flow
W->>CH: getDecrypted(credentialId)
CH->>DB: Fetch encrypted credential data
DB-->>CH: Data (JSON)
CH->>CH: Decrypt data
CH->>CO: usesManagedAuth(type, data)
alt NEW: Is Managed OAuth Credential
CO-->>CH: true
CH->>CO: getOverwrites(type)
CO-->>CH: Overwrite map (e.g. environment variables)
loop For each Pinned Field (authUrl, grantType, etc.)
CH->>CT: Get property definition for field
CT-->>CH: Property (type: hidden, default: "...")
alt NEW: Admin Overwrite exists
CH->>CH: Set field to Admin Overwrite value
else NEW: Fallback to Type Definition
CH->>CH: CHANGED: Set field to Credential Type default value
end
Note right of CH: User-provided values for these<br/>fields are now ignored/discarded
end
else Standard Credential
CO-->>CH: false
CH->>CH: Use values from decrypted stored data
end
CH->>CH: Apply remaining non-pinned defaults
CH-->>W: Resolved Credential Object (Ready for API call)
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
guillaumejacquart
approved these changes
Aug 24, 2026
afitzek
added this pull request to the merge queue
Aug 24, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For managed OAuth credentials — where the instance supplies the OAuth client
through credential overwrites — the OAuth endpoint and flow fields now resolve
from the credential type definition instead of the stored credential data.
Key implementation decisions
stored data was already set, with no data migration.
dynamic-client-registration branch, so it does not depend on the defaults
pass keeping hidden fields.
Related
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)