Skip to content

perf(core): Chunk package ID lookups - #36923

Draft
NourAlhadi wants to merge 1 commit into
masterfrom
ligo-1025-package-exportimport-post-benchmarking-improvements
Draft

perf(core): Chunk package ID lookups#36923
NourAlhadi wants to merge 1 commit into
masterfrom
ligo-1025-package-exportimport-post-benchmarking-improvements

Conversation

@NourAlhadi

@NourAlhadi NourAlhadi commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Split package-sized ID lookups into bind-safe query batches.
  • Merge workflow, shared-workflow, and folder results across batches.
  • Cover recursive folder subtree lookups and multi-branch workflow matching.

How to test

  1. Run pnpm --filter @n8n/db typecheck.
  2. Run the affected database repository and chunk-helper tests.
  3. Run the CLI finder tests.
  4. Run the folder repository integration test with SQLite.
  5. Run the package import and export integration tests.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/LIGO-1025

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

🤖 PR Summary generated by AI

Made with Cursor

Review in cubic

Co-authored-by: Cursor <cursoragent@cursor.com>
@n8n-assistant

n8n-assistant Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

PR review overview

Based on ownership of the 15 changed files in this PR:

Ownership Files owned Share Source code Test files Misc
@n8n-io/catalysts 14 93% +214 / -110 +225 / -4 +0 / -0
@n8n-io/adore 1 7% +2 / -6 +0 / -0 +0 / -0
Total 15 100% +216 / -116 +225 / -4 +0 / -0

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ages/@n8n/db/src/repositories/folder.repository.ts 58.82% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant Bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant