fix(ai-builder): Fix session timeline/trace not showing on preview dock when full screen - #36930
Open
aaguirre-rdit wants to merge 2 commits into
Open
fix(ai-builder): Fix session timeline/trace not showing on preview dock when full screen#36930aaguirre-rdit wants to merge 2 commits into
aaguirre-rdit wants to merge 2 commits into
Conversation
Contributor
PR review overviewBased on ownership of the 6 changed files in this PR:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Architecture diagram
sequenceDiagram
participant User
participant Dock as AgentPreviewDock
participant Chat as AgentPreviewChatPage
participant Timeline as AgentSessionTimelinePanel
participant Parent as Agent Builder / Editor
Note over User,Parent: Flow: User clicks "View Session Trace" (list-tree icon)
User->>Dock: click viewTrace()
alt Layout is Full Screen
Dock->>Dock: NEW: Set dockView = 'timeline'
Dock->>Chat: NEW: Hide via v-show
Dock->>Timeline: NEW: Render AgentSessionTimelinePanel
else Layout is Docked
Dock->>Parent: CHANGED: emit('view-trace')
end
Note over User,Parent: Flow: Navigation within Full Screen Dock
alt User clicks "Show Chat"
User->>Dock: click showChat()
Dock->>Dock: NEW: Set dockView = 'chat'
Dock->>Timeline: NEW: Unmount component
Dock->>Chat: NEW: Show via v-show
else User clicks "New Chat"
User->>Dock: click createNewSession()
Dock->>Dock: NEW: Call showChat() internal reset
Dock->>Parent: emit('new-session')
end
Note over Dock: Watchers for State Reset
alt layout changed OR dock closed OR session lost
Dock->>Dock: NEW: Reset dockView to 'chat'
Dock->>Chat: Ensure chat is visible for next open
end
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Bundle ReportChanges will increase total bundle size by 5.44kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently in the agent builder preview chat, when the preview layout is set to Full Screen (fullpage) instead of Docked, clicking the timeline icon (view session trace) does not switch the view to the session timeline.
Now we render the session trace timeline on the same full screen component rather than activating it on the docked component.
How to test
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AGENT-704/bug-agent-builder-preview-timeline-icon-does-not-switch-to-timeline-in
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)