refactor: Set up env config #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
approved these changes
Nov 25, 2024
Contributor
tomi
left a comment
tomi
left a comment
There was a problem hiding this comment.
Good idea to refactor this 👍 Left couple comments
| const ( | ||
| // ------------------------ | ||
| // auth | ||
| // ------------------------ |
Contributor
There was a problem hiding this comment.
Maybe we could use
// #region auth
...
// #endregion authto make these foldable
Member
Author
There was a problem hiding this comment.
Apparently not supported for Go? https://share.cleanshot.com/5lyhDHfR
Contributor
There was a problem hiding this comment.
Oh I thought I tested it and it worked but seems it only folded the start of the comment :/ Yeah doesn't seem to be supported
Co-authored-by: Tomi Turtiainen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is setup for runner health monitoring to be done at https://linear.app/n8n/issue/PAY-2280
envpackageN8N_RUNNERS_SERVER_ENABLEDandN8N_RUNNER_URIto required envs