Skip to content

Reject invalid fragmented payloads - #257

Merged
TMRh20 merged 2 commits into
masterfrom
DefragmentationBugFix
Jun 26, 2025
Merged

Reject invalid fragmented payloads#257
TMRh20 merged 2 commits into
masterfrom
DefragmentationBugFix

Conversation

@TMRh20

@TMRh20 TMRh20 commented Jun 26, 2025

Copy link
Copy Markdown
Member
  • On Arduino, there is a need to reject invalid fragmented payloads with less than 2 fragments

- On Arduino, there is a need to reject invalid fragmented payloads with less than 2 fragments
@TMRh20
TMRh20 requested a review from 2bndy5 June 26, 2025 08:29
- header->reserved is used for header->type on the last fragment. Allow low numbers for the last fragment

@2bndy5 2bndy5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. What could possibly cause a single fragmented frame to be 1 fragment long? I'm guessing this is another side effect of rogue ACK packets.

@TMRh20

TMRh20 commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

What could possibly cause a single fragmented frame to be 1 fragment long? I'm guessing this is another side effect of rogue ACK packets.

That or some other 'external activities'

@TMRh20
TMRh20 merged commit 061b9de into master Jun 26, 2025
20 checks passed
@TMRh20
TMRh20 deleted the DefragmentationBugFix branch June 26, 2025 16:20
2bndy5 pushed a commit that referenced this pull request Nov 27, 2025
* Reject invalid fragmented payloads

- On Arduino, there is a need to reject invalid fragmented payloads with less than 2 fragments

* Slight modification

- header->reserved is used for header->type on the last fragment. Allow low numbers for the last fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants