Skip to content

fix: use const for max BLE payload size#30

Merged
2bndy5 merged 2 commits intomainfrom
const-ble-payload-size
Apr 6, 2025
Merged

fix: use const for max BLE payload size#30
2bndy5 merged 2 commits intomainfrom
const-ble-payload-size

Conversation

@2bndy5
Copy link
Copy Markdown
Member

@2bndy5 2bndy5 commented Apr 6, 2025

This replaces the magic number which was inconsistent between RX and TX BLE operations.

This also avoids possible malformed outgoing payloads because 28 was previously used where 27 is the correct maximum.

replaces the magic number which was inconsistent between RX and TX operations.
This also avoids possible malformed outgoing payloads because the 28 was previously used where 27 is the correct maximum.
@2bndy5 2bndy5 added the bug Something isn't working label Apr 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1513ada) to head (aeded67).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         3154      3154           
=========================================
  Hits          3154      3154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

at least till it is fixed upstream...
@2bndy5 2bndy5 merged commit b563d4a into main Apr 6, 2025
41 checks passed
@2bndy5 2bndy5 deleted the const-ble-payload-size branch April 6, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant