Add .gitginore to Module Scaffolding #2130
Open
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I have been using this package for couple months. Let's say I installed module called
Ticketing. Inside of it there areModules/Ticketing/resources/js/app.js,Modules/Ticketing/resources/sass/app.scss,composer.json,package.json. This mean that we can install isolated dependencies inside ofTicketingmodule without polluting or mixing it with the root project.As we know, if deps installed it will generate the
node_modulesandvendordirectories. Those of directories are not ignored. So, when we switch git branch (for example), thenode_modulesandvendorfromTicketingmodule will be exposed. I think it's better to set default.gitignoreeach time module is generated. 😉I know we can do it manually after generate module. But, as we know sometimes humans tends to forget and sometimes we believe that this package cover this case but it doesn't (yet). Also, I want to help to make this package much better.