Skip to content

fix: admin visible competitions #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: admin visible competitions #1017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
091fb50
Make public competitions visible for admins.
lukaskogaborik May 5, 2025
ee0e3ab
Linter fix
lukaskogaborik May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bullet/competitions/models/competitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def for_user(self, user: "User", branch: "Branch"):
roles = CompetitionRole.objects.filter(
user=user, competition__branch=branch
).values("competition")
return qs.filter(id__in=roles)
competitions = roles.union(qs.filter(results_public=True).values("id"))
return qs.filter(id__in=competitions)

def for_photos(self, user: "User", branch: "Branch"):
"""
Expand All @@ -68,7 +69,8 @@ def for_photos(self, user: "User", branch: "Branch"):
roles = CompetitionRole.objects.filter(
user=user, competition__branch=branch
).values("competition")
return qs.filter(id__in=roles)
competitions = roles.union(qs.filter(results_public=True).values("id"))
return qs.filter(id__in=competitions)


class Competition(models.Model):
Expand Down