Skip to content

fix #874 update gRPC client connection handling to support DNS resolu…#875

Open
RightFS wants to merge 1 commit into
nacos-group:masterfrom
RightFS:master
Open

fix #874 update gRPC client connection handling to support DNS resolu…#875
RightFS wants to merge 1 commit into
nacos-group:masterfrom
RightFS:master

Conversation

@RightFS
Copy link
Copy Markdown

@RightFS RightFS commented Mar 20, 2026

  1. 将 grpc.WithInsecure() 替换为 grpc.WithTransportCredentials(insecure.NewCredentials())
  2. 将 grpc.Dial(...) 替换为 grpc.NewClient(...)
  3. 添加 google.golang.org/grpc/credentials/insecure 导入
  4. 使用 net.ParseIP() 判断serverInfo.serverIp是否为 IP 地址,如果返回 nil 则说明是域名,拼上 dns:/// 前缀。同时要加 "net" 到 import
  5. 顺带处理3处warning

修改后逻辑如下

address := serverInfo.serverIp + ":" + strconv.FormatUint(rpcPort, 10)
// 如果是域名(非 IP),加 dns:/// 前缀,让 gRPC 使用 DNS resolver
if net.ParseIP(serverInfo.serverIp) == nil {
    address = "dns:///" + address
}
return grpc.NewClient(address, opts...)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 20, 2026

CLA assistant check
All committers have signed the CLA.

@Sunrisea
Copy link
Copy Markdown
Member

我看你的分支里面混杂了很多其他人的提交,这边建议是基于最新分支拉个新分支出来进行开发哈, 方便进行review

@RightFS
Copy link
Copy Markdown
Author

RightFS commented Apr 16, 2026

我看你的分支里面混杂了很多其他人的提交,这边建议是基于最新分支拉个新分支出来进行开发哈, 方便进行review

啊? 这项目还有人管啊, 我以为死了呢...有人管的话我处理一下

@RightFS
Copy link
Copy Markdown
Author

RightFS commented Apr 16, 2026

已清理pr, 现在只有一次commit, 一个文件的修改, 大佬看看吧 @Sunrisea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants