issues87 修复在多个/多级SpringContext并存环境下,EventPublishingConfigService发送事件混乱,引发后续依赖事…#260
Open
ittxy wants to merge 1 commit intonacos-group:masterfrom
Open
issues87 修复在多个/多级SpringContext并存环境下,EventPublishingConfigService发送事件混乱,引发后续依赖事…#260ittxy wants to merge 1 commit intonacos-group:masterfrom
ittxy wants to merge 1 commit intonacos-group:masterfrom
Conversation
…件机制的系列问题,如@NacosValue注解无法解析到最新值
Author
|
@Nacos 注解在项目启动后,修改无法更新的 复现 样例代码地址是 https://github.com/ittxy/nacos-bug-in-spring-context |
Author
|
该PR:需要分别在applicationContext.xml与servlet.xml中同时注册NacosConfig(EnableNacosConfig配置一致),因为父容器无法感知子容器的存在。 #87 |
|
zhijie.zheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…件机制的系列问题,如@NacosValue注解无法解析到最新值
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
修复在多个/多级SpringContext并存环境下,EventPublishingConfigService发送事件混乱,引发后续依赖事件机制的系列问题,如@NacosValue注解无法解析到最新值
Brief changelog
Verifying this change
2.CacheableEventPublishingNacosServiceFactory拥有字段(ConfigurableApplicationContext context),它能作为单例使用的前提条件是,应用的只有存在一个容器单独使用Nacos,而多个SpringContext同时使用Nacos,就可能引发创建的ConfigService是(上一个SpringContext创建的,被缓存)
3.基于以上,此PR删除CacheableEventPublishingNacosServiceFactory.getSingleton()获取单例的方法,将CacheableEventPublishingNacosServiceFactory对象的创建关联到容器
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.