Minor cleanup #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. make jtag_dtm_t an internal detail of remote_bitbang_t. This ensures that it gets deleted when remote_bitbang_t is deleted, preventing a memory leak. . consolidate socket closing into a function called from the destructor and when needed.
nadime15
pushed a commit
that referenced
this pull request
Oct 29, 2025
. make jtag_dtm_t an internal detail of remote_bitbang_t. This ensures that it gets deleted when remote_bitbang_t is deleted, preventing a memory leak. . consolidate socket closing into a function called from the destructor and when needed.
nadime15
pushed a commit
that referenced
this pull request
Nov 25, 2025
. make jtag_dtm_t an internal detail of remote_bitbang_t. This ensures that it gets deleted when remote_bitbang_t is deleted, preventing a memory leak. . consolidate socket closing into a function called from the destructor and when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. make jtag_dtm_t an internal detail of remote_bitbang_t. This ensures that it gets deleted
when remote_bitbang_t is deleted, preventing a memory leak.
. consolidate socket closing into a function called from the destructor and when needed.