Minor cleanup in remote_bitbang.
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `close_ports()` since it is not called anymore. - `execute_commands()` can be simplified to `tick()` since it is now called only after a connection has been accepted.
nadime15
pushed a commit
that referenced
this pull request
Oct 29, 2025
* Minor cleanup in `remote_bitbang`. - Remove `close_ports()` since it is not called anymore. - `execute_commands()` can be simplified to `tick()` since it is now called only after a connection has been accepted. * Run only as long as we have an active connection to OpenOCD.
nadime15
pushed a commit
that referenced
this pull request
Nov 25, 2025
* Minor cleanup in `remote_bitbang`. - Remove `close_ports()` since it is not called anymore. - `execute_commands()` can be simplified to `tick()` since it is now called only after a connection has been accepted. * Run only as long as we have an active connection to OpenOCD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
close_ports()since it is not called anymore.execute_commands()can be simplified totick()since it is now called only after a connection has been accepted.Run only as long as we have an active connection to OpenOCD.