Skip to content

Fix memory corruption in mkstr caused by integer overflow #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nook24 merged 2 commits into from
Mar 18, 2026
Merged

Fix memory corruption in mkstr caused by integer overflow #527

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c25d5d3
Fix memory corruption in mkstr caused by integer overflow
nook24 Mar 17, 2026
6a22f40
refactor: improve portability of timeval string formatting
nook24 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ Breaking changes:
Features:
* new attribute 'check_timeout' on `host` and `service` structs, overrides the global host / service check timeouts. (#525)

Bugfixes:
* fix memory corruption in `mkstr` caused by integer overflow (#527)

1.5.0 - Feb 03 2026
===================
Breaking changes:
Expand Down
2 changes: 1 addition & 1 deletion lib/nsutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ int str2timeval(char *str, struct timeval *tv)
const char *mkstr(const char *fmt, ...)
{
static char buf[MKSTR_BUFS][32]; /* 8k statically on the stack */
static int slot = 0;
static unsigned int slot = 0;
char *ret;

va_list ap;
Expand Down
Loading