Skip to content

Bugfix/corbett bytestostring :: Python3 Support#56

Open
asciifaceman wants to merge 14 commits intonaftulikay:masterfrom
asciifaceman:bugfix/corbett-bytestostring
Open

Bugfix/corbett bytestostring :: Python3 Support#56
asciifaceman wants to merge 14 commits intonaftulikay:masterfrom
asciifaceman:bugfix/corbett-bytestostring

Conversation

@asciifaceman
Copy link
Contributor

@asciifaceman asciifaceman commented Feb 5, 2021

Sorry for the commit spam - squash on merge to clean that up.

  • Python3 support

Tested on 3.8.5

Python3 introduces more aggression around the difference between str and bytes, apparent in a few operations degoss.py was performing


  • Update binary download to just use shutil - it is chunking and buffering in the background anyways and response is a file-like object (response.read() becomes bytes in py3 and it was having encoding issues)
  • Update subprocess to use utf8 encoding (IO becomes bytes in py3)

---- Should fix #47

@asciifaceman asciifaceman changed the title Bugfix/corbett bytestostring Bugfix/corbett bytestostring :: Python3 Support Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3

1 participant