Conversation
This will prioritise the .NET 10 build making it easier to contribute to the library on non Windows devices.
This allows a single method definition to work for all targeted frameworks.
Although the classes doesn't allow the dictionaries to be modified after construction, this is a more formal way of declaring the intent.
The currencies have no mutable state but there are multiple instances of some created so using singletons will reduce the memory footprint of the library at runtime.
Member
|
Thanks for the input, there are some interesting and good approaches there. Is it okay with you if I incorporate some of your ideas? I don't want to include the entire pull request as a whole at this point. Or would you like to split it into individual pull requests? |
Author
|
Of course, feel free to use as much or as little of the ideas as you want. If you don’t want to take all of it, would the easiest option be for you to make a separate branch and I can redirect the PR to that instead of individual PRs at which point you could pick and choose what you like from there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I was playing about with your project and have a few suggestions, here's a PR in case you're interested in any of them.