Skip to content

Suggestion: China - Wait until holidays are officially announced #1075

Description

@gwilym

More information

For China, the API returns schedules for future years the government hasn't announced. As of today, GET /api/v3/PublicHolidays/2027/CN already returns a full 2027 list (New Year, Spring Festival 02-06, Labour Day, Dragon Boat, Mid-Autumn, National Day).

These are computed from ChineseLunisolarCalendar in ChinaHolidayProvider.cs, not from an official source. There's no gate on whether a schedule has been announced, and it emits only the single principal day per festival (no 调休 makeup/observed days).

China's schedule is set annually by the State Council (国务院办公厅关于节假日安排的通知 / Notice from the General Office of the State Council Regarding Holiday Arrangements), published ~Oct–Dec of the prior year. That notice defines the real observed days and makeup workdays. So a predicted year is incomplete by construction and can differ from what's gazetted, and API consumers can't tell prediction from fact.

Is it worthwhile trying to predict a single date like this? I'd suggest not, at least not without something in the data model / API to mark it as unconfirmed.

Note: I'm not in China, nor do I understand Mandarin Chinese, I just happen to be using this data at the moment. I'll defer to anyone with deeper China holiday experience. For my own use, I'm considering skipping this China data altogether given its unconfirmed nature.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions