feat: Implement translation synchronization for seeded entities.#70
Closed
AntonioNav wants to merge 2 commits intonaiba:mainfrom
Closed
feat: Implement translation synchronization for seeded entities.#70AntonioNav wants to merge 2 commits intonaiba:mainfrom
AntonioNav wants to merge 2 commits intonaiba:mainfrom
Conversation
Owner
|
Thanks for the PR. Could you fix https://github.com/naiba/bonds/actions/runs/23302517009/job/67767321276 ? |
naiba
added a commit
that referenced
this pull request
Mar 20, 2026
Re-translate all default seeded labels (genders, pronouns, religions, etc.) to match the current locale via POST /settings/personalize/sync. Covers both account-level and vault-level entities. Custom labels are unaffected (only rows with a non-null translation key are updated). Also adds es locale support to the Accept-Language middleware. Closes #70 Co-authored-by: naiba/CloudCode <hi+cloudcode@nai.ba>
Owner
|
Thanks for identifying this issue and submitting a PR! I've implemented this feature in #71 (merged and released as v0.7.5), covering both account-level and vault-level seeded entities with full test coverage. If you're interested in continuing to contribute, it would be great to have a standalone PR that adds Spanish (es) locale support — the translation files ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you change the language settings to a language other than the one used during registration, the labels that are initially loaded will remain in the original language. This change is intended to update the preloaded labels. Obviously, custom labels are not changed and remain as they are.