naiserator requires string-bool, not real bool for allow-redirects #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianNymark
commented
Jan 9, 2026
| !!! info "Explicit redirect permission" | ||
| The ingress being redirected has to have `nais.io/allow-redirect: true` set. | ||
| This can be set as an annotation in the application spec. | ||
| The ingress being redirected has to set the following |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this is the best way to do it, but I wanted to be more explicit about the docs yaml, since newbies might not be super familiar with the yaml structure? Or maybe they are, and a link to the example full yaml is better? Having a big multiline code block inside this alert/panel is not ideal 😅
Contributor
Author
There was a problem hiding this comment.
the important part was to get "true" in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like the docs have a small mistake (missing some quotes around true)
relevant failing build
https://github.com/navikt/webapps-felgen/actions/runs/20845261937/job/59887409648
potentially relevant line in naiserator:
https://github.com/nais/naiserator/blob/master/pkg/resourcecreator/ingress/redirect.go#L51
Really glad for nais-doc having a nix flake by the way 🤩, makes it easy to install deps and set up config, didn't have to deal with
asdf,poetry,make... one is usually not super motivated to go through those motions when it's just a small typo fix, so having nix flake == ❤️!