Upgrade from Zig 0.12 to 0.14 #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 14 out of 29 changed files in this pull request and generated no comments.
Files not reviewed (15)
- build.zig: Language not supported
- build.zig.zon: Language not supported
- lib/ini/build.zig: Language not supported
- lib/ini/build.zig.zon: Language not supported
- lib/ini/example/example.zig: Language not supported
- lib/ini/src/ini.zig: Language not supported
- lib/ini/src/lib-test.zig: Language not supported
- lib/ini/src/lib.zig: Language not supported
- lib/ini/src/test.zig: Language not supported
- lib/nif/build.zig: Language not supported
- src/lightning/LndConf.zig: Language not supported
- src/nd.zig: Language not supported
- src/nd/Config.zig: Language not supported
- src/nd/Daemon.zig: Language not supported
- src/nd/network.zig: Language not supported
Member
Author
|
Selecting "LIGHTNING" tab in UI crashes ngui process on Nakamochi (but not on my PC) with this change. |
Member
Author
|
I messed up my git setup, so re-created my fork, this was automatically closed by GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24.
Replaced ini with current master version. I'm not a fan of just copying other repos in a source tree like this, would prefer using git submodules instead. Many devs hate submodules because they often forgot to run
git submodulecommands, but I think that would not be a problem ifbuild.zigwould handle that automatically.