Fixing potential crash in readline function caused by neglecting resu… #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing potential crash in readline function caused by neglecting result of realloc.
sqlite3 crashed if using "select rowid, value, name from fileio_scan('README.md');"
Problem found and fixed using Claude. Here the explanation:
The issue here is that when realloc is called, it may return a new pointer while freeing the old one. If this happens, p would still be pointing to the old memory block, which has been freed. Continuing to use p after this point could lead to memory corruption.
The correct approach would be to adjust p after realloc to point to the corresponding position in the newly allocated memory.