Merged
Conversation
Closed
3 tasks
grarco
reviewed
Jul 18, 2025
| pub fn inf(&self, rhs: &Self) -> Self { | ||
| let mut comps = BTreeMap::new(); | ||
| for (atype, rhs_amount) in rhs.components() { | ||
| // rhs_amount is positive by definition |
Contributor
There was a problem hiding this comment.
Does this guarantee comes from the fact that notes always carry positive amounts? Cause ValueSums could actually carry any type
Contributor
Author
There was a problem hiding this comment.
Ah, you're correct. I made a bad assumption. I think the issue is now fixed.
grarco
approved these changes
Jul 18, 2025
batconjurer
approved these changes
Jul 21, 2025
murisi
force-pushed
the
murisi/dot-product
branch
from
56c9c01 to
cecf8d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Namada MASP client needs a way to select transaction input notes in such a way that the number of notes used is minimized (in order to reduce the number of spend descriptions and hence overall size of MASP transactions and gas consumption). To facilitate the writing of such an algorithm, this PR implements more operations for
ValueSum, specifically:ValueSumis covered by anotherValueSumcomponentschecked!(...)contextsAdditionally, usage of the
Defaulttrait has been replaced with theZerotrait where zero was actually needed. As forValueSumitself, an implementation ofZerohas been added to it (to complement the existingDefaultimplementation).