Improve compatibility with zcash incrementalmerkletree upstream crate#101
Merged
tzemanovic merged 2 commits intomainfrom Jul 28, 2025
Merged
Improve compatibility with zcash incrementalmerkletree upstream crate#101tzemanovic merged 2 commits intomainfrom
incrementalmerkletree upstream crate#101tzemanovic merged 2 commits intomainfrom
Conversation
grarco
approved these changes
Jul 21, 2025
Contributor
Author
|
sorry, just added some missing convenience methods |
sug0
force-pushed
the
tiago/update-incrementalmerkletree
branch
from
5774de4 to
c74146b
Compare
sug0
changed the title
incrementalmerkletree upstream crate
grarco
approved these changes
Jul 21, 2025
murisi
reviewed
Jul 22, 2025
Contributor
murisi
left a comment
murisi
left a comment
There was a problem hiding this comment.
Thanks! I don't see any logical issues with this code. But to be on the safe side, I just left some questions here. Probably I'm just missing a little context here...
Contributor
Author
|
@murisi I think ultimately it might be better to get rid of |
sug0
force-pushed
the
tiago/update-incrementalmerkletree
branch
from
c74146b to
f8144b2
Compare
murisi
approved these changes
Jul 24, 2025
Contributor
murisi
left a comment
murisi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
sug0
force-pushed
the
tiago/update-incrementalmerkletree
branch
from
f8144b2 to
ffdcd0a
Compare
tzemanovic
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incrementalmerkletreecloses #90