Skip to content

prepare to publish on crates.io#89

Merged
tzemanovic merged 8 commits intomainfrom
tomas/pre-pub
Jan 13, 2025
Merged

prepare to publish on crates.io#89
tzemanovic merged 8 commits intomainfrom
tomas/pre-pub

Conversation

@tzemanovic
Copy link
Contributor

@tzemanovic tzemanovic commented Jan 9, 2025

@tzemanovic tzemanovic marked this pull request as ready for review January 10, 2025 17:25
@tzemanovic tzemanovic requested a review from murisi January 10, 2025 17:25
Copy link
Contributor

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@tzemanovic tzemanovic merged commit 571f123 into main Jan 13, 2025
21 checks passed
@Rigorously
Copy link

This broke the Namada MASP Indexer due to the num-traits dependency namada-net/namada-masp-indexer#35

@sug0
Copy link
Contributor

sug0 commented Jan 19, 2025

The masp indexer is still using the SDK tagged with v0.46.0. This PR shouldn't have broken the build of namada-masp-indexer. What it looks like might happened is num-traits upstream broke semver with a patch release, which are implicitly bumped...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants