Implemented checked multiplication for ValueSums.#94
Merged
tzemanovic merged 1 commit intomainfrom Mar 20, 2025
Merged
Conversation
murisi
force-pushed
the
murisi/checked-mul
branch
from
24deff7 to
d38ab0e
Compare
grarco
approved these changes
Mar 10, 2025
batconjurer
approved these changes
Mar 10, 2025
tzemanovic
approved these changes
Mar 11, 2025
tzemanovic
force-pushed
the
murisi/checked-mul
branch
from
d38ab0e to
cb0e665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements checked multiplication for
ValueSums. This is required when applying conversions that might results in overflow in Namada.