Merged
Conversation
grarco
force-pushed
the
grarco/improve-tx-accepted
branch
from
e38e51e to
f8c87f8
Compare
Fraccaman
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the checks on accepted inner transactions to also verify that the corresponding wrapper was successful (this covers the case in which an inner tx succeeds but then the entire batch is discarded because of something wrong with another tx of the batch).
As suggested by @Fraccaman, it also ensures that we only index gas only when all the txs in a batch are successful: in all the other cases the gas used is not guaranteed to be enough to cover the actual gas cost of the transaction and indexing these values will lead to wrong estimations provided to the clients