Skip to content

fix: remove the filter for claimed rewards in find_rewards_by_delegator_and_validator_and_epoch#371

Merged
Fraccaman merged 1 commit intomainfrom
fix/remove-claimed-filter-from-epoch-reward
Jun 2, 2025
Merged

fix: remove the filter for claimed rewards in find_rewards_by_delegator_and_validator_and_epoch#371
Fraccaman merged 1 commit intomainfrom
fix/remove-claimed-filter-from-epoch-reward

Conversation

@neocybereth
Copy link
Copy Markdown
Contributor

This was removed here when we were resolving the error where claimed balance wasn't being updated in Namadillo's Unclaimed Staking Balance panel (which was my fault from here.

For this endpoint, however, we don't want to filter the claimed rewards b/c we're querying to find the total rewards a user was paid per epoch. So we mustn't filter claimed rewards b/c otherwise each claimed epoch would give us []

Here's what a successful query looks like:

$ curl -s https://indexer.namada.tududes.com:443/api/v1/pos/reward/tnam1qpumagd04vvc5c8552se32na7wrhvvganc0lj82r/tnam1q8lhvxys53dlc8wzlg7dyqf9avd0vff6wvav4amt/661
[{"minDenomAmount":"66940323","validator":{"address":"tnam1q8lhvxys53dlc8wzlg7dyqf9avd0vff6wvav4amt","votingPower":"10385382","maxCommission":"0.01","commission":"0.05","state":"consensus","name":"ValidityOps#1","email":"operations@validityops.com","website":"https://validityops.com","description":"🛡️Shields Up for Secure and Reliable Staking — Supporting the Namada Ecosystem!","discordHandle":null,"avatar":"https://avatars.githubusercontent.com/u/183962636?s=200&v=4","validatorId":"124","rank":null}}]

Here's what the current query looks like:

$ curl -s https://indexer.namada.tududes.com:443/api/v1/pos/reward/tnam1qr0evqhw9u0yqy9d5zmtq0q8ekckhe2vkqc3ky/tnam1q8lhvxys53dlc8wzlg7dyqf9avd0vff6wvav4amt/660

@neocybereth neocybereth requested a review from Fraccaman May 18, 2025 03:04
@Fraccaman Fraccaman added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit 422c0e8 Jun 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants