Merged
Conversation
4acd1c6 to
b257152
Compare
b257152 to
d3c26f6
Compare
d3c26f6 to
501a507
Compare
501a507 to
04f7cf7
Compare
113d703 to
4466920
Compare
4466920 to
5d05767
Compare
Collaborator
|
LGTM, the only thing I would change is to remove all the |
sug0
reviewed
Mar 12, 2025
| validator.id, | ||
| ) | ||
| }) | ||
| .collect::<Vec<_>>(), |
Collaborator
There was a problem hiding this comment.
Suggested change
| .collect::<Vec<_>>(), | |
| .collect::<anyhow::Result<Vec<_>>>()?, |
you can collect a result to avoid the .expect()
| addresses: &HashSet<BondAddresses>, | ||
| ) -> anyhow::Result<Vec<Redelegation>> { | ||
| let redelegations = futures::stream::iter(addresses) | ||
| .filter_map(|BondAddresses { source, target }| async move { |
Collaborator
There was a problem hiding this comment.
we can propagate the errors. this will filter failing queries
| }) | ||
| .map(futures::future::ready) | ||
| .buffer_unordered(20) | ||
| .collect::<Vec<_>>() |
Collaborator
There was a problem hiding this comment.
basically collect a result of a vec, again
| validator_addresses: Vec<Id>, | ||
| ) -> anyhow::Result<Vec<Redelegation>> { | ||
| let nested_delegations = futures::stream::iter(validator_addresses.clone()) | ||
| .filter_map(|validator_address| async move { |
957b377 to
89189c1
Compare
grarco
reviewed
Mar 13, 2025
grarco
approved these changes
Mar 14, 2025
Fraccaman
reviewed
Mar 14, 2025
| epoch_switch_blocks_delay INT NOT NULL, | ||
| checksums JSONB NOT NULL | ||
| checksums JSONB NOT NULL, | ||
| slash_processing_epoch_offset INT NOT NULL |
Collaborator
There was a problem hiding this comment.
shouldn't this be in a separate migration ?
Collaborator
Author
There was a problem hiding this comment.
Yeah totally missed that
94dbebd to
e24d4db
Compare
sug0
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "results": [ { "amount": "20.000000", "validator": { "address": "tnam1qyeajuacps8rcqd4fxq506am20sz22s7yypekcd5", "votingPower": "16155", "maxCommission": "0.02", "commission": "0.02", "state": "consensus", "name": null, "email": null, "website": null, "description": null, "discordHandle": null, "avatar": null, "validatorId": "188" }, "redelegationInfo": { "earliestRedelegationEpoch": "450", "earliestRedelegationTime": "1742963267" } } ], "pagination": { "page": 1, "perPage": 30, "totalPages": 1, "totalItems": 2 } }slash_processing_epoch_offset