End epochs for continuous PGF distributions#4408
Open
brentstone wants to merge 6 commits intomainfrom
Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4408 +/- ##
==========================================
- Coverage 74.53% 74.51% -0.03%
==========================================
Files 339 339
Lines 110504 110592 +88
==========================================
+ Hits 82368 82407 +39
- Misses 28136 28185 +49 ☔ View full report in Codecov by Sentry. |
639dc1d to
8177ad2
Compare
171ee31 to
b2b8ca2
Compare
488f1b2 to
4223b7f
Compare
Contributor
🧪 CI InsightsHere's what we observed from your CI run for ce57eff. ✅ Passed Jobs With Interesting Signals
|
33520aa to
a86158f
Compare
a86158f to
ce57eff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4104. Affects Ledger test vectors and input data format for the
init-proposaltx.Required migrations:
tx_init_proposal.wasmfundings_key)Contains a breaking changes for a Ledger wallet integration (proposal adding CPGF may have end epoch and proposal removing CPGF have a proposal ID that added a target that's being removed), witnessed by the failing
test-ledger-appjob https://github.com/namada-net/namada/actions/runs/19338771064/job/55321230842?pr=4408. This will require an update toinit_proposalparser.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo