Skip to content

End epochs for continuous PGF distributions#4408

Open
brentstone wants to merge 6 commits intomainfrom
brent/cpgf-end-epochs
Open

End epochs for continuous PGF distributions#4408
brentstone wants to merge 6 commits intomainfrom
brent/cpgf-end-epochs

Conversation

@brentstone
Copy link
Collaborator

@brentstone brentstone commented Feb 22, 2025

Describe your changes

Closes #4104. Affects Ledger test vectors and input data format for the init-proposal tx.

Required migrations:

  • update tx_init_proposal.wasm
  • migrate any active CPGFs to a new storage format (under fundings_key)

Contains a breaking changes for a Ledger wallet integration (proposal adding CPGF may have end epoch and proposal removing CPGF have a proposal ID that added a target that's being removed), witnessed by the failing test-ledger-app job https://github.com/namada-net/namada/actions/runs/19338771064/job/55321230842?pr=4408. This will require an update to init_proposal parser.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone added the breaking:SDK SDK breaking change label Feb 22, 2025
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 70 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (7ca07c9) to head (8177ad2).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/pgf/inflation.rs 31.25% 33 Missing ⚠️
crates/governance/src/finalize_block.rs 16.66% 20 Missing ⚠️
crates/governance/src/storage/proposal.rs 73.80% 11 Missing ⚠️
crates/sdk/src/signing.rs 94.11% 4 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4408      +/-   ##
==========================================
- Coverage   74.53%   74.51%   -0.03%     
==========================================
  Files         339      339              
  Lines      110504   110592      +88     
==========================================
+ Hits        82368    82407      +39     
- Misses      28136    28185      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/cpgf-end-epochs branch from 639dc1d to 8177ad2 Compare February 27, 2025 03:49
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 27, 2025
@brentstone brentstone force-pushed the brent/cpgf-end-epochs branch from 171ee31 to b2b8ca2 Compare March 2, 2025 10:03
@brentstone brentstone added the enhancement New feature or request label Mar 2, 2025
@tzemanovic tzemanovic removed the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Mar 27, 2025
@brentstone brentstone added the breaking: tx Transaction format breaking change label Jun 16, 2025
@tzemanovic tzemanovic force-pushed the brent/cpgf-end-epochs branch from 488f1b2 to 4223b7f Compare October 17, 2025 14:24
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2025

🧪 CI Insights

Here's what we observed from your CI run for ce57eff.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (2) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@tzemanovic tzemanovic marked this pull request as draft November 13, 2025 16:08
@tzemanovic tzemanovic added the requires-migration Requires DB migration to update some state label Nov 13, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Nov 13, 2025
@tzemanovic tzemanovic force-pushed the brent/cpgf-end-epochs branch from 33520aa to a86158f Compare November 13, 2025 16:37
@tzemanovic tzemanovic marked this pull request as ready for review November 13, 2025 17:03
@tzemanovic tzemanovic force-pushed the brent/cpgf-end-epochs branch from a86158f to ce57eff Compare November 14, 2025 18:37
@brentstone brentstone added this to the Priorities > v201.0.7 milestone Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change breaking:SDK SDK breaking change breaking: tx Transaction format breaking change enhancement New feature or request governance ledger requires-migration Requires DB migration to update some state

Projects

None yet

Development

Successfully merging this pull request may close these issues.

continuous PGF proposals should have beginning and end epoch options

2 participants