Display payment addresses instead of extended full viewing keys in test vectors#4436
Closed
Display payment addresses instead of extended full viewing keys in test vectors#4436
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
- Coverage 74.50% 74.49% -0.01%
==========================================
Files 339 339
Lines 110638 110641 +3
==========================================
- Hits 82432 82425 -7
- Misses 28206 28216 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tzemanovic
reviewed
Mar 3, 2025
Cargo.toml
Outdated
| madato = "0.7" | ||
| masp_primitives = { version = "1.2" } | ||
| masp_proofs = { version = "1.2", default-features = false, features = ["local-prover"] } | ||
| masp_primitives = { git = "https://github.com/anoma/masp", rev = "badb4b00e2ea358f4051069c7d0ab66ff76b694c" } |
Collaborator
There was a problem hiding this comment.
we should make a release before merging
Collaborator
There was a problem hiding this comment.
this is ready to use in version 1.3.0
tzemanovic
approved these changes
Mar 3, 2025
9b44d85 to
a3e2cbc
Compare
…enders in test vectors.
a3e2cbc to
5554ab4
Compare
brentstone
approved these changes
Mar 15, 2025
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
An attempt to reduce the amount of screens clicked through on the hardware wallet for shielded/unshielding transactions. This is done by displaying the payment address of a note as the sender (similar to what the Zcash Ledger app does) instead of the extended full viewing key that owns it. This reduces the number of screens required to display a sender from 8 to 3. I.e. there's now 5 less screens to click though, which reduces the amount of time required to sign a shielded transaction once the display lag is considered. Alternative options were considered like displaying just a full viewing key or an incoming viewing key instead of the extended full viewing key, but these do not already have bech32 encodings in Namada nor can they be used in any of the existing interfaces. See attached what the new test vectors would look like: testvecs-fmted.json.gz and testdbgs.txt.gz.
This PR depends upon namada-net/masp#92 to obtain the payment addresses of transaction input notes.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo