feat(registry/client): add possibility to block some settings #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-nc
requested review from
b1ff,
blackrabbit99,
harnyk,
m2broth,
wRLSS and
yehor-manzhula
stas-nc
force-pushed
the
feature/protectedsettings
branch
from
bb4ed99 to
f4ce9e2
Compare
stas-nc
force-pushed
the
feature/protectedsettings
branch
from
f4ce9e2 to
e7b6c0a
Compare
b1ff
reviewed
Aug 22, 2025
| error: error || settingError, | ||
| loaded: !isResourceLoading, | ||
| loading: isResourceLoading, | ||
| loaded: !isResourceLoading && 'true', |
Contributor
There was a problem hiding this comment.
this condition looks strange. I assume that due to some weird types, but anyway if we can correct it would be good
Member
Author
There was a problem hiding this comment.
There is an issue with React-Admin that complains in the console about wrong prop types passed to the component:
Warning: Received `true` for a non-boolean attribute `loaded`.
If you want to write it to the DOM, pass a string instead: loaded="true" or loaded={value.toString()}.
I assume it wants to be set as an attribute directly, not as a {...props} object.
After the update to the latest React-Admin, we'll probably remove this.
| Example: | ||
|
|
||
| ```bash | ||
| export ILC_REGISTRY_ADMIN_PROTECTED_SETTINGS="setting1,setting2" |
Contributor
There was a problem hiding this comment.
as far as I see it impacts frontend and webpack compilation, which means that if you set this setting on runtime - it won't have any effect
Contributor
There was a problem hiding this comment.
@stas-nc the documentation says
Set this variable **before starting the application** to specify which settings should be blocked from editing in the admin UI.
Member
Author
There was a problem hiding this comment.
It was meant to be set before the webpack build.
I've added the possibility to change it in the container runtime as well, updated the documentation.
Coverage ReportIlc/serverCommit SHA:0cb94d6933e9d4f3c863beb66926247e99b64f5f Test coverage results 🧪File details
Ilc/clientCommit SHA:0cb94d6933e9d4f3c863beb66926247e99b64f5f Test coverage results 🧪File details
RegistryCommit SHA:0cb94d6933e9d4f3c863beb66926247e99b64f5f Test coverage results 🧪File details
|
m2broth
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to block/protect certain settings from being modified in the registry client. Fixed some ui errors as well.