Skip to content

face: introduce HTTP/3 WebTransport listener #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yoursunny
Copy link
Member

No description provided.

Copy link
Member

@zjkmxy zjkmxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Haven't tested, though.

@zjkmxy zjkmxy requested a review from Copilot April 20, 2025 00:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for an HTTP/3 WebTransport listener to the application.

  • Introduces HTTP/3 configuration in the YAML and core config files.
  • Implements new HTTP3Transport and HTTP3Listener types to handle WebTransport sessions.
  • Updates URI handling to support the new "quic" scheme and integrates the listener in the command startup.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
fw/yanfd.sample.yml Adds HTTP3 configuration section.
fw/face/http3-transport.go Implements transport logic for HTTP/3 WebTransport connections.
fw/face/http3-listener.go Introduces the listener for HTTP/3 WebTransport sessions.
fw/defn/uri.go Adds support for generating QUIC/HTTP3 URIs and updates URI decoding.
fw/defn/uri_test.go Extends tests to cover the new QUIC URI format.
fw/core/config.go Extends configuration to include HTTP3 settings.
fw/cmd/yanfd.go Integrates HTTP3 listener instantiation into the server startup flow.
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (2)

fw/face/http3-listener.go:98

  • [nitpick] Consider logging or otherwise handling the error from l.server.Upgrade to aid troubleshooting when the upgrade fails.
if e != nil { return }

fw/defn/uri_test.go:88

  • [nitpick] Expand test coverage for QUIC URIs to verify that canonical properties and proper URI string formatting are maintained, as done for other protocols.
uri = defn.DecodeURIString("quic://[::1]:443")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants