fix(pdf-manager): detect PDFRadioGroup fields instead of classifying as text - #660
Merged
kydecker merged 1 commit intoJun 24, 2026
Merged
Conversation
…as text The PDF Manager classified every non-checkbox field as "text", so radio groups were mislabeled and rendered with the text icon. Add explicit PDFRadioGroup detection via a fieldType() helper and a new "radio" field type, with a matching radio icon in the field list. Closes namesakefyi#659
kydecker
approved these changes
Jun 24, 2026
kydecker
left a comment
Member
There was a problem hiding this comment.
Tested and everything works! Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PDF Manager at
/pdf-managerwas classifyingPDFRadioGroupfields astext. The detection inextractFieldsFromBytesonly special-casedPDFCheckBoxand treated everything else astext, so radio groups got the wrong type and were shown with the text icon (noticed in #656, the first uploaded form that contains radio groups).Changes
pdf-manager/lib/pdf.ts– add a smallfieldType()helper that mapsPDFCheckBox→checkbox,PDFRadioGroup→radio, and everything else →text, and add"radio"toPdfFieldInfo["type"].pdf-manager/src/types.ts– add"radio"toField["type"].pdf-manager/src/components/FieldList.tsx– render a radio icon forradiofields.The schema generation in
lib/schema.tsalready records the rawconstructor.name, so generated schemas keep flagging these fields asPDFRadioGroup.Testing
Built an in-memory PDF with a text field, a checkbox and a radio group, then ran
extractFieldsFromByteson it.Before:
After:
tsc --noEmitandbiome checkboth pass.Closes #659