Remove componentWillReceiveProps warning.#651
Remove componentWillReceiveProps warning.#651arturcarvalho wants to merge 2 commits intonamespace-ee:mainfrom
Conversation
|
@arturcarvalho thank you for this PR. Maybe we can change this to use componentDidUpdate instead? I mean if we are removing it eventually why not do it now. |
|
I'm not sure what you mean about componentDidUpdate, because that should be after the render, and componentWillReceiveProps is before. I've changed it to use getDerivedStateFromProps, it seems to be the closest to it. Running the project and going through the examples looks good. I get the "Maximum call stack size exceeded", although I got it also before. |
|
Any update on this? |
|
Can we get this PR merged please? |
|
It's been almost a year. Maybe a fork is a good solution. |
|
What is status on this issue ? Failing to update that could potentially break support for the new React 18. |
|
This PR has been marked as outdated. Here's why: The issue this PR fixed — replacing the deprecated
The deprecation warning is no longer an issue since the component has been completely rewritten. Thank you for the contribution! The idea/fix was appreciated even if the codebase has moved on. |
Fix for #642.
I've ran the
npx react-codemod react-to-react-dom <path>to fix the CustomHeader. This is sort of a quick fix, maybe later I can look at the code and try to change it to a proper fix.I've npm linked and tested it in a project and it looks good, no errors.
The tests pass, but the
npm run lintshowed a lot of errors. Not sure if this is normal.I may have some time available during the weekend, so if there's any changes to be done on the branch just let me know.
Hope this helps!