Issue 500 diagonal scroll trackpad#873
Issue 500 diagonal scroll trackpad#873Billgonzo123 wants to merge 9 commits intonamespace-ee:mainfrom
Conversation
… Allows for y mouse movement checking
|
The |
|
oops, this was supposed to be a draft! |
…prevents confusion and bugs when a touchpad scroll is a diagonal
…read the windows current x position since x is not being modified
|
This PR has been marked as outdated. Here's why: The file this PR targets ( The current version is 0.30.0-beta.5 and uses TypeScript, dayjs (instead of moment), and Vite (instead of Webpack). Thank you for the contribution! The idea/fix was appreciated even if the codebase has moved on. |
Issue Number: 500
Link to issue
I restored the code from v0.21.0 and it has restored the functionality of touch pad diagonal scrolling. It does seem that on most browser you must initially move your fingers in a diagonal motion because scrolling seems to be locked to the initial direction of scrolling per event.
I have added a small bit of code so that when clicking inside the calendar component it can be dragged on the X and Y axis. To do this I turned
dragStartPositioninto an object containingxandyscroll values. I then usedragStartPosition.yto update the windows scroll position.I also fixed a bug with the shiftKey modifier when scrolling. deltaY was prioritized in a ternary resulting in glitchy and confusing movement when touchpad scrolling was diagonal. deltaX is now prioritized.