Demo/move resize items moves timeline when item close to left right border#875
Open
davidbejarcaceres wants to merge 5 commits intonamespace-ee:mainfrom
Conversation
…to demo/MoveResize-items-moves-timeline-when-item-close-to-left-right-border
Member
|
This PR has been marked as outdated. Here's why: This PR modified
If auto-scroll during drag/resize near borders is still a desired feature, it would need to be reimplemented from scratch against the current TypeScript codebase. Thank you for the contribution! The idea/fix was appreciated even if the codebase has moved on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution for issue #783.
Use the
moveResizeValidator()function to move/resize an item close to the left/right border of the timeline, and auto scroll the timeline bounds to the direction of the move/resize item. By doing this you can keep moving/resizing the item without to stop, move timeline and move/resize again and item.Overview of PR
Move item left/right
Here you can see the functionality to auto scroll timeline when move item close to left/right borders:
React-Calendar-Timeline.Move.mp4
Resize edges of item left/right
Now for resize item close to left/right borders:
React-Calendar-Timeline.Resize.mp4
Check tests passed
Yes, no errors when running
yarn run test, no many changes to library itself, just extra params to themoveResizeValidatorfunction in Iitem.js.