You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR added a verticalMarginBetweenStackedItems boolean prop to control vertical spacing between stacked items. The codebase has since been rewritten from JavaScript to TypeScript (v0.30.0-beta.5), and this feature has been superseded by a more flexible approach: the new itemVerticalGap prop (a number, not a boolean) now provides precise control over the vertical gap between stacked items. It works alongside itemHeightRatio and takes precedence when specified. The stacking logic in src/lib/utility/calendar.tsx already uses itemVerticalGap throughout. Additionally, this PR targeted files that no longer exist in their original form — src/lib/Timeline.js is now src/lib/Timeline.tsx, tests have been migrated from Enzyme to @testing-library/react, and the __fixtures__ and __tests__ files referenced have been restructured.
Thank you for the contribution! The idea/fix was appreciated even if the codebase has moved on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #888