You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A function that's called when the user tries to scroll. Call the passed updateScrollCanvas(start, end) with the updated visibleTimeStart and visibleTimeEnd (as unix timestamps in milliseconds) to change the scroll behavior, for example to limit scrolling.
This PR modified src/lib/Timeline.js (a JavaScript class component) to include selectedItem in the isInteractingWithItem check, which controlled whether onTimeChange was triggered during item drags. The entire codebase has since been rewritten from JavaScript to TypeScript — the target file is now src/lib/Timeline.tsx. Additionally, the scroll and interaction logic has been refactored in v0.30.0-beta.5, and the isInteractingWithItem variable in the current code (!!draggingItem || !!resizingItem) is used in a different context. The specific behavioral issue from #838 would need to be re-evaluated against the current TypeScript implementation to determine if it still exists.
Thank you for the contribution! The idea/fix was appreciated even if the codebase has moved on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#838
Link issue.
I think that is a misunderstanding with the bug, why it should have been called onTimeChange when I drag i item?
docs:
onTimeChange(visibleTimeStart, visibleTimeEnd, updateScrollCanvas, unit)
A function that's called when the user tries to scroll. Call the passed
updateScrollCanvas(start, end)with the updated visibleTimeStart and visibleTimeEnd (as unix timestamps in milliseconds) to change the scroll behavior, for example to limit scrolling.