Open
Conversation
Member
|
@developer-ocansey — Flagging this for your review. Recommendation: Concept worth adopting, but implementation needs rework What it doesAdds an Why it's valuableItem collision detection is a useful feature for scheduling applications. Knowing when items overlap after a drag/resize lets consumers enforce constraints, show warnings, or auto-resolve conflicts. Issues with the current implementation
Suggested approach for a fresh implementation
Effort estimateMedium — the concept is straightforward but should be built on the existing collision infrastructure rather than ported from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
#523
Overview of PR
We added the functionality to detect collision between items in the same group.
Now you can detect collisions doing:
Authors of commit @GabrielCrackPro @albertoncp @terox