Solve process-compose related "FIX ME" in flake.nix - #66
Open
arjunkathuria wants to merge 1 commit into
Open
Conversation
Updates process-compose part in flake.nix file which was marked as a "FIX ME" in a previous iteration as relevant. Should now be on parity with what it used to be before.
srid
approved these changes
Jan 9, 2024
Comment on lines
+30
to
+31
| beckn-gateway.command = lib.getExe self'.packages.beckn-gateway; | ||
| mock-registry.command = lib.getExe self'.packages.mock-registry; |
Member
There was a problem hiding this comment.
lib.getExe is redundant here, because command is a sum type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Updates a process-compose related "FIX ME" in flake.nix file which was marked as such in a previous iteration
Should now be on parity with what it used to be before.
Additional Changes
Motivation and Context
During the update to GHC 9.2.7, process-compose-flake version got implicitly upgraded as-well.
The newer process-compose-flake version was incompatible with the older syntax present in the repo for it and thus was marked as a fix-me, to be looked at later.
Finally got around to solving the previous "FIX ME".
How did you test it?
Built on local. DevShell builds, cabal project builds.
Checklist
./dev/format-all-files.sh