Skip to content

enh: allow international codes in the updateCities API #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaypalmudaliyar24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enh: allow international codes in the updateCities API #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/mock-registry/src/Flow/UpdateCities.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ validateCities :: [Text] -> Either Text ()
validateCities = \case
[] -> Left "Cities cannot be empty"
cities -> do
let patternStr = "^std:[0-9]{2,8}$"
let patternStr = "^(std|area):[0-9]{2,8}$"
invalidCities = filter (isNothing . matchRegex (mkRegex patternStr) . T.unpack) cities
_ <- case invalidCities of
[] -> Right ()
xs -> Left $ "cities " <> T.pack (show xs) <> " doesn't match the regex pattern:" <> T.pack patternStr
xs -> Left $ "cities " <> T.pack (show xs) <> " doesn't match the regex pattern:\'" <> T.pack patternStr <> "\'"
bool (Right ()) (Left "Cities cannot have duplicates") $ hasDuplicates cities