fix: make SimpleFunction directory able to upload#628
Merged
DavidSouther merged 2 commits intonand2tetris:mainfrom Feb 3, 2026
Merged
Conversation
DavidSouther
reviewed
Feb 2, 2026
Collaborator
DavidSouther
left a comment
DavidSouther
left a comment
There was a problem hiding this comment.
Could you please add a unit test showing the failing and (now) passing behavior?
Contributor
Author
|
Thanks for your review. The vm.test.ts and vm.ts are updated to add a unit test which detect the assertion failed error in memory.ts when invalid property of the stack object are passed. |
DavidSouther
approved these changes
Feb 3, 2026
mmatsumoto1026
deleted the
fix/make-SimpleFunction-directory-able-to-upload
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #621
This PR will make SimpleFunction directory able to upload without the runtime error by returning empty array as the values property of the stack object, when the number of items on the stack for the current function frame is equal to or less than zero.