Add timeout support to ReadSignal.until method#127
Merged
Conversation
Contributor
Author
|
@nank1ro 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Deploying solidart-docs with
|
| Latest commit: |
9dc1282
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2f483321.solidart.pages.dev |
| Branch Preview URL: | https://copilot-fix-125.solidart.pages.dev |
Co-authored-by: nank1ro <60045235+nank1ro@users.noreply.github.com>
Co-authored-by: nank1ro <60045235+nank1ro@users.noreply.github.com>
Co-authored-by: nank1ro <60045235+nank1ro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add timeout to ReadSignal.until
Add timeout support to ReadSignal.until method
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
timeoutparameter to theReadSignal.untilmethod to prevent memory leaks and provide better control over asynchronous signal waiting.Background
In issue #124, a user created an extension method that included timeout functionality for
ReadSignal, noting that the existinguntilmethod was missing timeout support. The library maintainer confirmed this gap and promised to add timeout functionality. The user specifically highlighted that using.timeout()wrapper on the future would result in leaked Effects that never get disposed.Changes
Core Implementation
Added an optional
Duration? timeoutparameter to theuntilmethod:The implementation:
Timerto complete withTimeoutExceptionwhen timeout expiresEffectandTimerto prevent memory leaksUsage Examples
Testing
Added comprehensive tests covering:
All 148 tests pass (143 existing + 5 new timeout tests).
Documentation
Updated the API documentation in
docs/api-docs/read-signal.mdxto include the new timeout parameter with usage examples.Benefits
TimeoutExceptionwhen timeout occursFixes #124.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl-ssl.google.comwget -qO- REDACTED(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.