Skip to content

Conversation

@pauchena
Copy link
Contributor

What's this PR do?

CU-86dtad91f

Copy link
Member

@ulises-jeremias ulises-jeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great PR! just some minor changes but the rest looks great 🔥

uses: actions/checkout@v3

- name: Set up Node
uses: actions/setup-node@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-node@v3
uses: actions/setup-node@v4

runs-on: ubuntu-latest
steps:
- name: Begin CI...
uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v3
uses: actions/checkout@v4

node-version-file: .node-version

- name: Install dependencies
run: npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npm install
run: pnpm install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may need to use this action to install pnpm before using it 😊 https://github.com/pnpm/action-setup

run: npm install

- name: Build page
run: npm run build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npm run build
run: pnpm run build

name: Deployment to GitHub Pages

permissions:
contents: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants