Add support for custom operator, effect, and value for tolerations#60
Open
AbiriAmir wants to merge 2 commits intonano-byte:masterfrom
Open
Add support for custom operator, effect, and value for tolerations#60AbiriAmir wants to merge 2 commits intonano-byte:masterfrom
AbiriAmir wants to merge 2 commits intonano-byte:masterfrom
Conversation
| nodeExclusions: | ||
| otherKey: [otherValue1, otherValue2] | ||
| tolerations: [someTaint] | ||
| tolerations: |
Member
There was a problem hiding this comment.
Suggested change
| tolerations: | |
| tolerations: |
Comment on lines
+90
to
+96
| ## Example: | ||
| ## tolerations: ["node.deepl.dev/k8s-kubevirt"] | ||
| ## Or you can add more complex tolerations as objects here | ||
| ## tolerations: | ||
| ## - key: "node.deepl.dev/k8s-gpu-worker" | ||
| ## effect: NoSchedule | ||
| ## value: "true" |
Member
There was a problem hiding this comment.
We don't have examples for any of the other values in values.yaml either.
Suggested change
| ## Example: | |
| ## tolerations: ["node.deepl.dev/k8s-kubevirt"] | |
| ## Or you can add more complex tolerations as objects here | |
| ## tolerations: | |
| ## - key: "node.deepl.dev/k8s-gpu-worker" | |
| ## effect: NoSchedule | |
| ## value: "true" |
Perhaps we can put this in the README.md instead?
Perhaps something like:
| `scheduling.tolerations` | `[]` | Taints on nodes this service can tolerate as strings or complex tolerations as objects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, toleration does not support custom values for effect, value, and operator. This pull request aims to address this issue.