refactor(nng-sys): remove cmake generator features#14
Merged
Conversation
Remove the cmake-* generator features. It's not generally the job of a `-sys` crate to dictate the means-of-build, that should be left to the user further "up". For example, the CMake generator is generally controlled globally through the `CMAKE_GENERATOR` environment variable, which the `cmake` crate already respects. This also simplifies the crate feature list and eliminates maintenance burden for tracking new Visual Studio versions. Not to mention it makes CI simpler since there are fewer "weird" combinations to try/skip.
Collaborator
Author
|
Ah, CI failed because this is a private repo, and therefore subject to your account limits @neachdainn 😅 |
flxo
approved these changes
Oct 17, 2025
Contributor
|
@jonhoo I intended to give you the ability to make the repo public (in fact, I meant to give you every permission except the ability to kick me out). If that isn't the case, let me know and I'll look at the permissions again. |
Collaborator
Author
|
@neachdainn Ah, no, I don't appear to have the rights to make this public. In fact, under the settings tab, I have very few permissions on this repo (e.g., I can't set CI variables either). |
Collaborator
Author
|
@neachdainn I'd also be happy for you to just make the project public directly :) |
Contributor
|
The repository is public now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the cmake-* generator features. It's not generally the job of a
-syscrate to dictate the means-of-build, that should be left to the user further "up". For example, the CMake generator is generally controlled globally through theCMAKE_GENERATORenvironment variable, which thecmakecrate already respects.This also simplifies the crate feature list and eliminates maintenance burden for tracking new Visual Studio versions. Not to mention it makes CI simpler since there are fewer "weird" combinations to try/skip.