Conversation
This imports the asynchronous nng bindings I wrote on top of nng-sys internally at Helsing. The docs + README should explain the what and how well, so I won't duplicate that here. Note that this currently produces warnings from cargo since anng has some examples that are named the same as examples in nng, which triggers rust-lang/cargo#6313.
flxo
reviewed
Oct 21, 2025
Collaborator
flxo
left a comment
flxo
left a comment
There was a problem hiding this comment.
Finally :-)
I checked manifest and READMEs but not the actual implementation.
jonhoo
added a commit
that referenced
this pull request
Oct 21, 2025
Just like, e.g., `openssl-sys` does. See also <https://doc.rust-lang.org/nightly/cargo/reference/build-script-examples.html#conditional-compilation>. This is needed so that, for example, #8 can make `anng`'s use of pub/sub dependent on having NNG version 1.10 or higher.
Collaborator
Author
|
The CI failure from |
jonhoo
added a commit
that referenced
this pull request
Oct 21, 2025
Just like, e.g., `openssl-sys` does. See also <https://doc.rust-lang.org/nightly/cargo/reference/build-script-examples.html#conditional-compilation>. This is needed so that, for example, #8 can make `anng`'s use of pub/sub dependent on having NNG version 1.10 or higher.
flxo
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This imports the asynchronous nng bindings I wrote on top of nng-sys internally at Helsing. The docs + README should explain the what and how well, so I won't duplicate that here.
Note that this does not add CI — instead, I'll rebase it on top of the upcoming PR that will add CI to the whole project.