This repository was archived by the owner on Mar 10, 2019. It is now read-only.
As Sentinel doesn't support AUTH command (as of Redis 4.0.7), passwor…#4
Open
aminet wants to merge 1 commit into
Open
As Sentinel doesn't support AUTH command (as of Redis 4.0.7), passwor…#4aminet wants to merge 1 commit into
aminet wants to merge 1 commit into
Conversation
…d must only be used for Master, as a result argument --sentinel-password doesn't make send but --master-password does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Context: 3 nodes under Debian Strech with backports (redis 4.0.7) with sentinel and redundis and an application which need to connect to a Redis server (a master with slaves in replication mode/auto-failover).
With redis configured without requirepass there is no problem.
But with requirepass set up :
./redundis -m mymaster -p ********************************************
2018-04-19 12:32:08 [redundis] INFO Listening on '127.0.0.1:6379'
2018-04-19 12:32:08 [redundis] INFO Monitoring master...
2018-04-19 12:32:08 [redundis] ERROR Failed to update master - Failed to reach sentinel - ERR unknown command 'AUTH'
The "missing" AUTH command on sentinel is known: https://github.com/antirez/redis/issues/3279#issuecomment-230485169 , so connecting to sentinel with NOAUTH is actually mandatory.
Sentinel could be fixed with https://github.com/antirez/redis/pull/3329
Until it append, this is a little PR as AUTH must only be used for Master (not on Sentinel) and as a result argument --sentinel-password doesn't make send but --master-password does